Fix crash in KeyStore due to non-unique key pair alias #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x7f
force-pushed
the
CHORE-fix-key-store-unique-id
branch
from
a457579 to
71f8cf1
Compare
If a user has installed multiple apps with this SDK, Android will throw an exception when the second app tries to use the same key pair alias. This will crash our SDK and the App. This commit makes sure the key is unique by including the property id in the string.
0x7f
force-pushed
the
CHORE-fix-key-store-unique-id
branch
from
71f8cf1 to
71b187a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user has installed multiple apps with this SDK, Android will throw an exception when the second app tries to use the same key pair alias. This will crash our SDK and the App. This commit makes sure the key is unique by including the property id in the string.