-
Notifications
You must be signed in to change notification settings - Fork 17
[16.0][MIG] account_invoice_provider_reference: Migration to 16.0 #387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 16.0
Are you sure you want to change the base?
Conversation
…e_provider_reference
…_invoice_provider_reference
Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>
Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>
polchampion
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| <field name="ref" position="after"> | ||
| <field | ||
| name="provider_reference" | ||
| invisible="context.get('default_move_type') not in ('in_invoice', 'in_refund','in_receipt')" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i see that this condition is used in the account.move tree view, but does it work on the form view?
for the form view, something like this is needed (to actually use the type of the account.move):
<field name="provider_reference" attrs="{'invisible': [('move_type', 'not in', ('in_invoice', 'in_refund', 'in_receipt'))]}" />| <field name="payment_reference" position="after"> | ||
| <field | ||
| name="provider_reference" | ||
| invisible="context.get('default_move_type') not in ('in_invoice', 'in_refund','in_receipt')" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a space is missing:
| invisible="context.get('default_move_type') not in ('in_invoice', 'in_refund','in_receipt')" | |
| invisible="context.get('default_move_type') not in ('in_invoice', 'in_refund', 'in_receipt')" |
14612