-
Notifications
You must be signed in to change notification settings - Fork 0
Fix basedpyright type errors and re-enable type checking #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Add _protocols.py with Protocol types for mixin pattern - Create execute.py with shared sandbox execution function - Fix Optional type annotations across approve.py, ssh.py, mix_remote.py - Add FSObject.kind attribute and fix method signatures in mix_vfs.py - Use TYPE_CHECKING for platform-specific struct definitions - Add type: ignore comments for mixin attribute accesses - Fix set.extend() -> set.update() bug in interact.py - Add None checks and class attribute annotations in test files - Update MCP server to use shared execute_script() function Reduces type errors from 97 to 0.
|
❌ CHANGELOG.md is out of date Please update the changelog by running: make changelogOr manually: git-cliff --config cliff.toml -o CHANGELOG.mdThen commit the updated |
|
❌ CHANGELOG.md is out of date Please update the changelog by running: make changelogOr manually: git-cliff --config cliff.toml -o CHANGELOG.mdThen commit the updated |
|
❌ CHANGELOG.md is out of date Please update the changelog by running: make changelogOr manually: git-cliff --config cliff.toml -o CHANGELOG.mdThen commit the updated |
|
❌ CHANGELOG.md is out of date Please update the changelog by running: make changelogOr manually: git-cliff --config cliff.toml -o CHANGELOG.mdThen commit the updated |
Summary
execute.pymodule for sandbox executionChanges
New Files
shannot/_protocols.py- Protocol types for mixin pattern typingshannot/execute.py- Shared sandbox execution function for CLI and MCP serverType Fixes
FSObject.kindattribute and fix method signatures inmix_vfs.pyOptionaltype annotations acrossapprove.py,ssh.py,mix_remote.pyTYPE_CHECKINGfor platform-specific struct definitions instructs.pytype: ignorecomments for mixin attribute accessesset.extend()→set.update()bug ininteract.pyexecute_script()functionCI/Pre-commit
.pre-commit-config.yamlcontinue-on-error: truefrom type checker step intest.ymlTest plan
uv run basedpyrightreports 0 errors