Return null duration instead of default from stopCollectingCacheInfo
#18199
+8
−19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If something calls
stopCollectingCacheInfo, there is no way to know if the elements had a duration, or if the default duration from config was used.This moves the application of the default to
\craft\services\TemplateCaches::endTemplateCache.Use-case
Craft Cloud uses
\craft\services\Elements::stopCollectingCacheInfoto collect tags and expiry for static cache. It has it's own default for static cache (1 year), but because a duration is always returned (even if it is just the default config fallback), there isn't a way to know if it actually came from an element.Notes
To avoid this kind of thing, future versions should separate cache duration settings by use-case, e.g.
templateCacheDuration, instead of sharing one config value.