-
-
Notifications
You must be signed in to change notification settings - Fork 33
Fix: Support multiple compose files in swarm mode #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Added file splitting logic for swarm mode (similar to compose mode) - Each file now gets its own -c flag in swarm deployments - Fixes issue where multiple files were treated as a single filename Before: docker stack deploy -c \"file1 file2\" stack-name After: docker stack deploy -c file1 -c file2 stack-name
Actions UpScanned 7 workflows, checked 17 actions and found 8 updates. Results
actions-up --exclude "cssnr/.*,actions/.*" --yes |
|
Since I use a real test and not a mock one it cant run on public PRs, but I checked out the PR locally and ran the test and it seems to work great. ✅ I also hate that GitHub has safe workflows disabled for new contributors by default. I enabled the Lint workflow. Looks like all you need to do is run Prettier on the README.md and it should be good to go. |
smashedr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great Work. Thanks for the contribution! 🚢
|
I wasn't sure what wasn't passing... just figured you might check it out yourself. I see it was the README I needed to reformat. I've now done that and it passes. I didn't know about the safe workflows thing though. |
Thank you too. |
Fix: Support multiple compose files in swarm mode (cssnr#46)
Before: docker stack deploy -c "file1 file2" stack-name
After: docker stack deploy -c file1 -c file2 stack-name
Overview
Checklist