Skip to content

Conversation

@theolujay
Copy link
Contributor

@theolujay theolujay commented Dec 14, 2025

  • Added file splitting logic for swarm mode (similar to compose mode)
  • Each file now gets its own -c flag in swarm deployments
  • Fixes issue where multiple files were treated as a single filename

Before: docker stack deploy -c "file1 file2" stack-name
After: docker stack deploy -c file1 -c file2 stack-name

Overview

Checklist

  • Verify the Required Checks are Passing
  • Document changes in the README.md (for new features)

- Added file splitting logic for swarm mode (similar to compose mode)
- Each file now gets its own -c flag in swarm deployments
- Fixes issue where multiple files were treated as a single filename

Before: docker stack deploy -c \"file1 file2\" stack-name
After:  docker stack deploy -c file1 -c file2 stack-name
@theolujay theolujay requested a review from smashedr as a code owner December 14, 2025 10:58
@github-actions github-actions bot added documentation Documentation updates workflows Workflows modification source Source modification labels Dec 14, 2025
@github-actions
Copy link

Actions Up

Scanned 7 workflows, checked 17 actions and found 8 updates.

Results
Name File Breaking Latest
hadolint/hadolint-action lint.yaml - v3.3.0
teunmooij/yaml test.yaml - v1.0.1
teunmooij/yaml test.yaml - v1.0.1
teunmooij/yaml test.yaml - v1.0.1
teunmooij/yaml test.yaml - v1.0.1
teunmooij/yaml test.yaml - v1.0.1
teunmooij/yaml test.yaml - v1.0.1
sarisia/actions-status-discord test.yaml - v1.15.5
actions-up --exclude "cssnr/.*,actions/.*" --yes

@smashedr
Copy link
Member

Since I use a real test and not a mock one it cant run on public PRs, but I checked out the PR locally and ran the test and it seems to work great. ✅

jarvis@jammy:~$ docker ps
CONTAINER ID   IMAGE                                      COMMAND                  CREATED              STATUS                PORTS                                                                                                          NAMES
160d81d66e27   alpine:latest                              "tail -f /dev/null"      About a minute ago   Up About a minute                                                                                                                    test_stack-deploy-compose-multi-alpine-1
5bb2e5e85cc4   alpine:latest                              "tail -f /dev/null"      About a minute ago   Up About a minute                                                                                                                    test_stack-deploy-multi_alpine.1.vzs3xjt75q0yf4102r3qnadqr
600ddb74af1f   smashedr/alpine-private:latest             "tail -f /dev/null"      About a minute ago   Up About a minute

I also hate that GitHub has safe workflows disabled for new contributors by default. I enabled the Lint workflow. Looks like all you need to do is run Prettier on the README.md and it should be good to go.

Copy link
Member

@smashedr smashedr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Work. Thanks for the contribution! 🚢

@theolujay
Copy link
Contributor Author

I wasn't sure what wasn't passing... just figured you might check it out yourself. I see it was the README I needed to reformat. I've now done that and it passes. I didn't know about the safe workflows thing though.

@theolujay
Copy link
Contributor Author

Great Work. Thanks for the contribution! 🚢

Thank you too.

@smashedr smashedr merged commit 28c3c6f into cssnr:master Dec 14, 2025
3 checks passed
theolujay added a commit to theolujay/stack-deploy-action that referenced this pull request Dec 18, 2025
Fix: Support multiple compose files in swarm mode (cssnr#46)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Documentation updates source Source modification workflows Workflows modification

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants