Added appropriate error for blank field name heading in record imports (D1099) #594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawelwlod
changed the title
lib/GADS/Import.pm
Outdated
| $search->{name_short} = $field if $self->short_names; | ||
| my $f_rs = $self->schema->resultset('Layout')->search($search); | ||
| error __x"Empty field name in import headings (Column {column})", column => $col_count | ||
| if !$field; |
Contributor
There was a problem hiding this comment.
I would use unless $field rather than if !$field - this is more personal preference, so I would run with that
In mind of OT comment "If it's 0, what happens" it's possible to use unless defined $field
Author
There was a problem hiding this comment.
Took a step further and accounted for all white-space characters using a regex statement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throw an error to the user if a field name heading is blank, alongside the column number in the CSV file being imported.