New Settings Page #405
Open
New Settings Page #405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AsenKimO
requested review from
JaysonHahn,
MrPeterss,
angelinaa-chen and
daniel-chuang
and removed request for
MrPeterss
MrPeterss
requested review from
ArielleNu and
MrPeterss
and removed request for
JaysonHahn and
daniel-chuang
MrPeterss
requested changes
Oct 10, 2025
Contributor
MrPeterss
left a comment
MrPeterss
left a comment
There was a problem hiding this comment.
Nice work! Take a look at my comments, and lets talk about how to do the 2x and 3x for the images.
Contributor
There was a problem hiding this comment.
can we rename this file? Vector-2.png doesn't seem like a great name
| }, | ||
| { | ||
| "idiom" : "universal", | ||
| "scale" : "2x" |
Contributor
There was a problem hiding this comment.
can you add the 2x and 3x versions of this? We can look at this together
| "scale" : "1x" | ||
| }, | ||
| { | ||
| "idiom" : "universal", |
Contributor
There was a problem hiding this comment.
here as well we need the 2x and 3x as well
| }, | ||
| { | ||
| "idiom" : "universal", | ||
| "scale" : "2x" |
| }, | ||
| { | ||
| "idiom" : "universal", | ||
| "scale" : "2x" |
| HStack { | ||
| VStack(alignment: .leading, spacing: 4) { | ||
| Spacer(minLength: 12) | ||
| Text("Notifications Access") |
| .font(Font(UIFont.preferredFont(forTextStyle: .body))) | ||
| .fontWeight(.semibold) | ||
| .foregroundColor(.black) | ||
| Text("Used to send device notifications") |
| .font(Font(UIFont.preferredFont(forTextStyle: .caption1))) | ||
| .fontWeight(.semibold) | ||
| .foregroundColor(.gray) | ||
| Spacer(minLength: 12) |
| .foregroundColor(.gray) | ||
| Spacer(minLength: 12) | ||
| } | ||
| Spacer() |
Contributor
There was a problem hiding this comment.
im going to stop commenting now just fix all the instances in this file
| Text("Shoot us an email") | ||
| .padding(EdgeInsets(top: 14, leading: 0, bottom: 14, trailing: 0)) | ||
| .font(Font(UIFont.preferredFont(forTextStyle: .body))) | ||
| Spacer() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Implemented most of the settings page, including the main page and 5 sub pages: About transit/appdev page, onboarding page, notifications/privacy page, support page, and TCAT service alerts page. Most subpages have designs that are inspired by Eatery's settings page and the rest are carried over from the previous design, but are tweaked to thematically fit the new settings page.
Changes Made
Change 1
Change 2
Issues
Test Coverage
Next Steps
Screenshots
Settings Page
settingspagev1.mov