Skip to content

Conversation

@gmorales96
Copy link
Contributor

@gmorales96 gmorales96 commented Dec 22, 2025

Summary by CodeRabbit

  • New Features

    • Swap financial institution is now available and supported across banking operations.
  • Chores

    • Vector financial institution removed from the list of supported banks.
    • Package version bumped to 2.1.7 to reflect these registry updates.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Dec 22, 2025

Walkthrough

This PR updates constant mappings and a version string. In clabe/banks.py it removes the mapping '608' -> '90608' and adds '730' -> '90730'; it also replaces the BANK_NAMES entry '90608': 'Vector' with '90730': 'Swap'. In clabe/version.py the module version is bumped from '2.1.6' to '2.1.7'. No logic or control flow is changed.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Review focus: ensure the new bank code/name pair is correct and the removed entry is intentionally deleted; verify version bump consistency.

Possibly related PRs

Suggested labels

enhancement

Suggested reviewers

  • felipao-mx
  • rogelioLpz

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main changes: adding Swap bank entry and removing Vector bank entry, which aligns with the actual modifications in BANKS and BANK_NAMES dictionaries.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch remove-vector-add-swap

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f8a3f02 and 5690642.

📒 Files selected for processing (1)
  • clabe/version.py
🧰 Additional context used
📓 Path-based instructions (1)
**/*.py

⚙️ CodeRabbit configuration file

**/*.py: Enforce Relative Imports for Internal Modules

Ensure that any imports referencing internal modules use relative paths. However, if modules reside in the main module directories (for example /src or /library_or_app_name) —and relative imports are not feasible—absolute imports are acceptable. Additionally, if a module is located outside the main module structure (for example, in /tests or /scripts at a similar level), absolute imports are also valid.

Examples and Guidelines:

  1. If a module is in the same folder or a subfolder of the current file, use relative imports. For instance: from .some_module import SomeClass
  2. If the module is located under /src or /library_or_app_name and cannot be imported relatively, absolute imports are allowed (e.g., from library_or_app_name.utilities import helper_method).
  3. If a module is outside the main module directories (for example, in /tests, /scripts, or any similarly placed directory), absolute imports are valid.
  4. External (third-party) libraries should be imported absolutely (e.g., import requests).

**/*.py:
Rule: Enforce Snake Case in Python Backend

  1. New or Modified Code: Use snake_case for all variables, functions, methods, and class attributes.
  2. Exceptions (Pydantic models for API responses):
    • Primary fields must be snake_case.
    • If older clients expect camelCase, create a computed or alias field that references the snake_case field.
    • Mark any camelCase fields as deprecated or transitional.

Examples

Invalid:

class CardConfiguration(BaseModel):
    title: str
    subTitle: str  # ❌ Modified or new field in camelCase

Valid:

class CardConfiguration(BaseModel):
    title: str
    subtitle: str  # ✅ snake_case for new/modified field

    @computed_field
    def subTitle(self) -> str:  # camelCase allowed only for compatibility
        return self.subtitle

Any direct use of camelCase in new or updated code outside of these exceptions should be flagged.

`*...

Files:

  • clabe/version.py
🔇 Additional comments (1)
clabe/version.py (1)

1-1: The patch version bump is appropriate for this change. The project treats bank list updates—synchronized from the official Banxico registry—as data maintenance rather than breaking API changes. Vector's removal reflects its removal from Banxico's official list of active financial institutions. The library's CLABE validation continues to work correctly; format validation is unaffected, and the change aligns with the project's documented versioning approach of maintaining the official bank registry data through patch-level updates.


Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Dec 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (cd52bed) to head (5690642).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #185   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines           83        83           
=========================================
  Hits            83        83           
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
clabe/banks.py 100.00% <ø> (ø)
clabe/version.py 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd52bed...5690642. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gmorales96 gmorales96 merged commit 485a019 into main Dec 22, 2025
15 checks passed
@gmorales96 gmorales96 deleted the remove-vector-add-swap branch December 22, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants