Add institutional email verification feature #2295
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 9 out of 11 changed files in this pull request and generated 2 comments.
Files not reviewed (2)
- dandiapi/api/templates/api/account/questionnaire_form.html: Language not supported
- dandiapi/api/templates/api/mail/verification_email.txt: Language not supported
Comments suppressed due to low confidence (1)
dandiapi/api/models/user.py:21
- The institutional_email field defaults to an empty string while the migration allows null; aligning these settings can prevent potential inconsistencies.
institutional_email = models.EmailField(blank=True, default='')
Comment on lines
+47
to
+48
| token_age = datetime.datetime.now(tz=datetime.UTC) - created_time | ||
| if token_age.total_seconds() > TOKEN_EXPIRATION_SECONDS: |
There was a problem hiding this comment.
Consider replacing 'datetime.UTC' with 'datetime.timezone.utc' to ensure correct timezone usage.
Suggested change
| token_age = datetime.datetime.now(tz=datetime.UTC) - created_time | |
| if token_age.total_seconds() > TOKEN_EXPIRATION_SECONDS: | |
| token_age = datetime.datetime.now(tz=datetime.timezone.utc) - created_time |
| verification_url = f"{settings.DANDI_API_URL}{reverse('verify-email')}?token={token}" | ||
|
|
||
| # Set the token creation time | ||
| user.metadata.verification_token_created = datetime.datetime.now(tz=datetime.UTC) |
There was a problem hiding this comment.
Replace 'datetime.UTC' with 'datetime.timezone.utc' for proper timezone handling in token creation.
Suggested change
| user.metadata.verification_token_created = datetime.datetime.now(tz=datetime.UTC) | |
| user.metadata.verification_token_created = datetime.datetime.now(tz=datetime.timezone.utc) |
Member
Author
There was a problem hiding this comment.
ruff wanted it the other way. I have no preference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1967
Cline-assisted