Do a proper logout #2679
Draft
Do a proper logout #2679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the correct way to "log the user out of the API", even if it involves users having to confirm their logout action. The reason for that, in turn, has to do with preventing CSRF attacks against a user's login state. The `ACCOUNT_LOGOUT_REDIRECT_URL` governs where the user is taken after logout completes. We can't use the logout view URL's `next` parameter because the redirect target is on a different domain from the backend.
This commit leaves the logout view broken (specifically, without any CSS styles, among other things). To "fix" it in dev, rename "base.html" to something else (so that the template engine grabs base.html from the allauth package instead).
Member
|
We discovered the |
jjnesbitt
reviewed
Jan 6, 2026
| localStorage.clear(); | ||
| } | ||
|
|
||
| window.location.href = 'http://localhost:8000/accounts/logout/' |
Member
There was a problem hiding this comment.
This should use the env var for the API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.