Remove unused embargo buckets

[mvandenburgh]

🚨 Setting this as draft until we are ready to delete the buckets, do not merge yet.

Removes the old embargo buckets that were used before the embargo redesign. Not having to support these buckets allows significant simplication of the dandiset_bucket module.

Fixes #210

[mvandenburgh]

I'll rebase this to include changes from #248 .

[mvandenburgh]

@sandyhider @NEStock I don't think EMBER ever made use of these buckets - these "embargo buckets" were previously used for embargoed data prior to a redesign where we consolidated all data into one bucket. I believe EMBER started after we did that switch, so I would expect these buckets to be empty. If they are not empty, they should be emptied prior to doing a terraform apply of this PR to avoid errors.

[NEStock]

@sandyhider @NEStock I don't think EMBER ever made use of these buckets - these "embargo buckets" were previously used for embargoed data prior to a redesign where we consolidated all data into one bucket. I believe EMBER started after we did that switch, so I would expect these buckets to be empty. If they are not empty, they should be emptied prior to doing a terraform apply of this PR to avoid errors.

@mvandenburgh Thanks for the heads up! I believe we are not currently using them, but we will definitely double check

[sandyhider]

I agree with Nicole. We looked into using them for a while with Private data but scrapped that plan.