Release new schema 0.7.0 for addition of the releaseNotes #344
Conversation
Reminder to myself: we run checks on no changes to schema only on PRs with "release" tag. Thus we did not run checks when we actually adjusted the schema in #185 by @bendichter. Then I rushed merging #341 as I was not expecting surprises from adjusting labels (forgot about above). The moral again, do not rush merging - let CI finish! ;)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #344 +/- ##
=======================================
Coverage 97.84% 97.84%
=======================================
Files 16 16
Lines 2042 2042
=======================================
Hits 1998 1998
Misses 44 44
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
dandi-cli is to fail since server can't validate new version of the schema as it doesn't know it. But otherwise I think it is ready and we could just release if dandi-archive is ready to accept devendorized schema version. (attn @dandi/archive-maintainers). @candleindark last look? |
This allows syncing of `dandischema` version with `dandi-archive` to resolve the `dandischema` versioning issue stated in dandi/dandi-schema#344 as part of the effort to address dandi/dandi-schema#299
candleindark
left a comment
candleindark
left a comment
There was a problem hiding this comment.
It looks OK to me.
However, now we need to have a new release of dandi-cli, dandi/dandi-cli#1744, to accompany the release of dandi/dandi-archive#2584 at the same time.
I have updated #299 accordingly.
This allows syncing of `dandischema` version with `dandi-archive` to resolve the `dandischema` versioning issue stated in dandi/dandi-schema#344 as part of the effort to address dandi/dandi-schema#299
This is a cut version of
which added a wishful component for allowing downgrading model versions. That would take more work, so will just progress now with releasing both new added releaseNotes and devendorization (#294), hence "minor" component boost for both schema and library
note:
dandi-clitests would fail since dandi-archive component would not be ready to publish with a new version of the schema ATM.