chore: cleanup code #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR updates the codebase to use PHP 8.1-compatible patterns by removing PHP 8.4 property hooks and adjusting readonly modifiers. It also removes internal development documentation.
- Converts property hooks to traditional getter method in Eip712Signer
- Moves readonly modifier from class-level to property-level for PHP 8.1 compatibility
- Removes internal CLAUDE.md development documentation file
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Auth/Signer/Eip712Signer.php | Replaced PHP 8.4 property hook syntax with traditional getAddress() method, updated all internal usages |
| src/Auth/ClobAuthenticator.php | Moved readonly keyword from class to individual properties, updated all references to use getAddress() method |
| src/Auth/ApiCredentials.php | Moved readonly keyword from class to individual properties for PHP 8.1 compatibility |
| CLAUDE.md | Removed internal development documentation file (dead code cleanup) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update code to support further PHP 8.1 patterns.
Remove dead code