feat: add message mapping from MIME to Graph JSON format #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Ciao Gabrio, thanks for the PR. This looks promising and like something I want to merge, but I will need some days until I get time to review it. Cheers, |
Author
|
That's perfect, no hurry at all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Understanding the possible issues with a custom mapping, the problem with previous implementation was that Django templates for html emails could not be used.
By adding a specific setting, we can maintain the plain mode for MIME email sending, and also enable the use of more advanced templates and the exploit of the Graph API.
I have added a few utility methods in MSGraphBackend to separate mapping and setting of headers and data for requests.