Skip to content

Conversation

@fahidattique55
Copy link

This has been tested by my team for multiple days and we did not found any multi-threading issue after QA. So I think i'ts stable now and you can merge it in new versions of it.

@Imperiopolis
Copy link

thank you for fixing this, I had been working on tracking the same problem. your fork seems to do the trick for me.


fileprivate func onMessage(_ message: Message) {

queue.sync {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this should use ActionCableSerialQueue ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Imperiopolis

I think sync operation can also be done with ActionCableSerialQueue. Btw, thanks for your thoughts.

allaire added a commit to agendrix/Swift-ActionCableClient that referenced this pull request Nov 29, 2019
@fahidattique55
Copy link
Author

@Imperiopolis @danielrhodes

Are you going to merge the pull request?

@Mathbl
Copy link

Mathbl commented Dec 9, 2019

Since the release of iOS 13, we noticed a lot of new crashes (com.ActionCableClient.Conccurent EXC_BAD_ACCESS KERN_INVALID_ADDRESS) related to Action Cable Client and usually pointing to swift_isUniquelyReferenced_nonNull_native.

We've been using this PR in production for a week and all those crashes are gone, so thank you for your contribution!

@fahidattique55
Copy link
Author

@Mathbl

Thanks for the appreciation. It means a lot.

@ConfusedVorlon
Copy link

@danielrhodes it would be great to see this merged.

Alternatively - if you're not able to maintain this project any more for whatever reason, it would be great if you could let people know so that someone else can step in.

thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants