Skip to content

Conversation

@glm4
Copy link

@glm4 glm4 commented May 6, 2019

Migrate swift version to 4.2 in all targets and dependencies.

@anphanngocvn
Copy link

@glm4 This latest upgrade doesn't stable. The onReceive callback works sometime (the same issue to version 0.2.4). However if I revert to 0.2.3, then it works very well.

@amakhonin
Copy link

@glm4 This latest upgrade doesn't stable. The onReceive callback works sometime (the same issue to version 0.2.4). However if I revert to 0.2.3, then it works very well.

this happens because if let item = idJSON.first { channelIdentifier = item.value as? String } in JSONSerializer, guess we need another fork..

@glm4
Copy link
Author

glm4 commented Jul 24, 2019

@glm4 This latest upgrade doesn't stable. The onReceive callback works sometime (the same issue to version 0.2.4). However if I revert to 0.2.3, then it works very well.

I guess that's not in the scope of this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants