-
Notifications
You must be signed in to change notification settings - Fork 223
Update github runners to oci gh arc runners #1326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Koray Oksay <koray.oksay@gmail.com>
|
@cicoyle could you please take a look, I am not sure how CNCF handles this and how Dapr Java SDK should be affected. |
Signed-off-by: Koray Oksay <koray.oksay@gmail.com>
cicoyle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @koksay - thanks for the PR here. Mind providing a link to a discussion or where I may find more information about the reason for this change?
Was there a particular reason for the dapr/java-sdk being chosen for this change? From a dapr ecosystem perspective, we will want consistency across all SDKs.
Will join and ask for clarification in the slack channel and provide additional context here for future reference |
|
@cicoyle is this still relevant? I am wondering if we could close this PR. |
|
Hey @artur-ciocanu, sorry — I didn't follow up on this PR. It's still relevant, for sure. As I stated at the beginning, these runners are no longer free, and we need to move all of them to the CNCF-hosted runners. I think @cicoyle mentioned on Slack that you prefer to align all SDKs; you may move the others as well. Here are the runner types: cc: @jeefy |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1326 +/- ##
============================================
+ Coverage 76.91% 78.67% +1.76%
- Complexity 1592 1957 +365
============================================
Files 145 217 +72
Lines 4843 5970 +1127
Branches 562 661 +99
============================================
+ Hits 3725 4697 +972
- Misses 821 932 +111
- Partials 297 341 +44 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
CNCF has hosted ephemeral GitHub runners on Oracle that we want projects to use instead of the GitHub-hosted ones, which now incur a cost to use.
Please direct any questions to me, @jeefy, @krook, and @RobertKielty. (or #cncf-ci-infra channel on the CNCF Slack)