Skip to content

Conversation

@salaboy
Copy link
Collaborator

@salaboy salaboy commented Dec 4, 2025

Description

Support the Dapr Workflow Dashboard Container

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1600

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@salaboy salaboy requested review from a team as code owners December 4, 2025 13:53
@salaboy salaboy changed the title Initial workflow dashboard config for testcontainers [WIP] Initial workflow dashboard config for testcontainers Dec 4, 2025
@salaboy salaboy self-assigned this Dec 4, 2025
@salaboy salaboy force-pushed the workflow-dashboard branch 2 times, most recently from a4186f2 to 31b1c7f Compare December 5, 2025 08:33
@salaboy salaboy changed the title [WIP] Initial workflow dashboard config for testcontainers Initial workflow dashboard config for testcontainers Dec 5, 2025
@salaboy
Copy link
Collaborator Author

salaboy commented Dec 5, 2025

@dapr/approvers-java-sdk @dapr/maintainers-java-sdk can you please provide feedback about this ?
This just add the Dapr Workflow Dashboard container to the Testcontainers module.

@salaboy salaboy force-pushed the workflow-dashboard branch from 49ea3a6 to cdcbaec Compare December 5, 2025 08:40
@salaboy salaboy requested a review from cicoyle December 10, 2025 14:27
salaboy and others added 8 commits December 10, 2025 16:53
Signed-off-by: salaboy <Salaboy@gmail.com>
Signed-off-by: salaboy <Salaboy@gmail.com>
Signed-off-by: salaboy <Salaboy@gmail.com>
* Adding a Flux based subscribeToEvents method

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>

* Simplify GRPC stream handling

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>

* Simplify Javadoc

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>

* Fix unit tests and simplify implementation

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>

* Adding event subscriber stream observer to simplify subscription logic

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>

* Use start() method to start stream subscription

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>

* Add unit test for event suscriber observer

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>

* Improve the tests a little bit

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>

* Remove the unnecessary method

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>

* Improve error handling and use CloudEvent wrapper

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>

* Fix unit tests asserts

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>

* Adjust Java examples for Subscriber

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>

---------

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>
Signed-off-by: salaboy <Salaboy@gmail.com>
Signed-off-by: salaboy <Salaboy@gmail.com>
* Remove SDK docs due to migration to main Docs repo

Signed-off-by: Marc Duiker <marcduiker@users.noreply.github.com>

* Remove sed lines related to sdk docs

Signed-off-by: Marc Duiker <marcduiker@users.noreply.github.com>

---------

Signed-off-by: Marc Duiker <marcduiker@users.noreply.github.com>
Co-authored-by: salaboy <Salaboy@gmail.com>
Signed-off-by: salaboy <Salaboy@gmail.com>
Signed-off-by: salaboy <Salaboy@gmail.com>
Signed-off-by: salaboy <Salaboy@gmail.com>
@codecov
Copy link

codecov bot commented Dec 10, 2025

Codecov Report

❌ Patch coverage is 60.00000% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.56%. Comparing base (d759c53) to head (879a962).
⚠️ Report is 241 commits behind head on master.

Files with missing lines Patch % Lines
...apr/testcontainers/WorkflowDashboardContainer.java 60.00% 11 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1601      +/-   ##
============================================
+ Coverage     76.91%   78.56%   +1.65%     
- Complexity     1592     1963     +371     
============================================
  Files           145      218      +73     
  Lines          4843     6000    +1157     
  Branches        562      662     +100     
============================================
+ Hits           3725     4714     +989     
- Misses          821      945     +124     
- Partials        297      341      +44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support DaprWorkflows Dashboard in Testcontainers

5 participants