Skip to content

In HTTP CONNECT, use hostname parsed from TLS SNI or HTTP Host header (renew #71) #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
andronoob wants to merge 11 commits into
base: master
Choose a base branch
from
Open

In HTTP CONNECT, use hostname parsed from TLS SNI or HTTP Host header (renew #71) #162

andronoob wants to merge 11 commits into from

Conversation

@andronoob
Copy link

@andronoob andronoob commented Apr 20, 2021 •
edited
Loading

This renews #71

@andronoob andronoob changed the title In HTTP CONNECT, use hostname parsed from TLS SNI (renew #71) In HTTP CONNECT, use hostname parsed from TLS SNI or HTTP Host header (renew #71) Apr 20, 2021
@andronoob andronoob marked this pull request as draft April 20, 2021 17:05
@andronoob
Copy link
Author

andronoob commented Apr 20, 2021 •
edited
Loading

Encountered this error:

redsocks: redsocks.c:1165: redsocks_relay_connected: Assertion `buffev == client->relay' failed.
Aborted (core dumped)

This happens while POSTing data.

Update: fixed this in c902860

@andronoob
Copy link
Author

andronoob commented Apr 20, 2021 •
edited
Loading

Oh this patch is was also affected by this issue: nodejs/http-parser#501

Update: fixed this in 809aa9c

@andronoob andronoob marked this pull request as ready for review April 21, 2021 06:32
@andronoob andronoob marked this pull request as draft April 21, 2021 06:41
@andronoob
Copy link
Author

andronoob commented Apr 21, 2021 •
edited
Loading

Protocols which are neither plaintext HTTP nor TLS are dropped. Something like "Invalid HTTP method" should not be a fatal error.

Fixed in 5755174

@andronoob andronoob marked this pull request as ready for review April 21, 2021 06:57
@andronoob andronoob marked this pull request as draft April 21, 2021 08:19
@andronoob
Copy link
Author

andronoob commented Apr 21, 2021 •
edited
Loading

Bad news, seemed to be double free memory corruption.😕

free(): invalid next size (fast)
Aborted (core dumped)

Still don't know how to reproduce this.

Update: this should be fixed in 9b0a5da

@andronoob andronoob marked this pull request as ready for review April 22, 2021 17:06
@andronoob andronoob mentioned this pull request Apr 25, 2021
Open
@tdferreira
Copy link

tdferreira commented Oct 29, 2024

@darkk there's nobody to review this?
It would be a must to have this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andronoob @tdferreira @tdzard94