Skip to content

added setgroups before setuid #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
luizluca wants to merge 1 commit into
base: master
Choose a base branch
from
Open

added setgroups before setuid #50

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions base.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,6 +392,11 @@ static int base_init()
}

if (instance.user) {
/* This executable is calling setuid and setgid without setgroups or initgroups.
* There is a high probability this mean it didn't relinquish all groups, and
* this would be a potential security issue to be fixed. Seek POS36-C on the web
* for details about the problem. */
setgroups(0, NULL);
if (setuid(uid) < 0) {
log_errno(LOG_ERR, "setuid(%i)", uid);
goto fail;
Expand Down