Fixes for non-linux platforms #95
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As splice(2) is Linux-specific, mark it as unsupported on non-linux systems. Furthermore, if splice is requested in the config but unsupported by the platform, report a warning to the user and ignore the config setting.
Check that splice(2) is available through the SPLICE_F_MOVE flag. If it is not, do not build anything splice-related and fall back to the buffer pump.
ipf is not available, at least on Debian GNU/kFreeBSD.
TCP_KEEPIDLE and friends are not portable.
LIST_HEAD is also defined in sys/queue.h on kFreeBSD. Rename our implementation to RED_LIST_HEAD to avoid clashes. Note that LIST_HEAD is currently unused.
darkk
force-pushed
the
master
branch
6 times, most recently
from
7fa694d to
5df6a30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
These changes make redsocks 0.5 build on non-linux platforms (tested on Debian GNU/KFreeBSD) again. The most important change is making
splice(2)support optional at build- and run-time, as well as using theTCP_KEEPIDLEsocket options et. al only when available.Regards,
Apollon