Update web library and ignore async_iterables #482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes dart-lang#480 async_iterables are a new type of member added to the Web IDL. Currently, we don't have an iterator type to produce anything useful so ignore for now.
Member
|
CI fun! |
Member
|
@srujzs – going to get back to this? Also: isn't this just |
Contributor
Author
|
Yes. This required a bit of updating of the other npm dependencies as well (specifically, the compatibility matrix. The smoke test failure is because this PR doesn't do that), so I still need to go through and make sure all the updated output with the new dependencies is reasonable. I'll do that later today/this week.
We could implement a JS type with a conversion to a Stream, but no such type exists yet. dart-lang/sdk#60457 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #480
async_iterables are a new type of member added to the Web IDL. Currently, we don't have an iterator type to produce anything useful so ignore for now.