Skip to content

Conversation

@xdustinface
Copy link

  • First commit fixes few issues unrelated to the rust-dashcore update probably from the merge of 3.0 into the platform wallet branch.
  • The second adjust the codebase for the recent wallet refactoring in rust-dashcore
  • The last commit adjusts the iOS build scripts to fix the build because there were some issue with incorrect lib paths.

Note: The iOS stuff still isn't adjusted to the latest FFI updates.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 29, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Dec 29, 2025

❌ gRPC Query Coverage Report

================================================================================
gRPC Query Coverage Report - NEW QUERIES ONLY
================================================================================

Total queries in proto: 51
Previously known queries: 47
New queries found: 4

================================================================================

New Query Implementation Status:
--------------------------------------------------------------------------------
✓ getAddressInfo                                /home/runner/work/platform/platform/packages/rs-sdk/src/platform/query.rs
✗ getAddressesBranchState                       NOT FOUND
✓ getAddressesInfos                             /home/runner/work/platform/platform/packages/rs-sdk/src/platform/fetch_many.rs
✗ getAddressesTrunkState                        NOT FOUND

================================================================================
Summary:
--------------------------------------------------------------------------------
New queries implemented: 2 (50.0%)
New queries missing: 2 (50.0%)

Total known queries: 51
  - Implemented: 46
  - Not implemented: 4
  - Excluded: 1

Not implemented queries:
  - getAddressesBranchState
  - getAddressesTrunkState
  - getConsensusParams
  - getTokenPreProgrammedDistributions

Missing NEW queries:
  - getAddressesBranchState
  - getAddressesTrunkState

@xdustinface xdustinface changed the title feat: Adjust platform wallet for latest rust-dashcore changes feat: adjust platform wallet for latest rust-dashcore changes Dec 29, 2025
@xdustinface xdustinface force-pushed the feat/ios-rust-dashcore-fix branch from 839eb7f to f64aa49 Compare December 29, 2025 17:08
@xdustinface xdustinface force-pushed the feat/ios-rust-dashcore-fix branch from f64aa49 to 9bbdbb4 Compare December 29, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants