Update variant_get to allow optional type
#17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
friendlymatthew
approved these changes
Nov 13, 2025
Member
friendlymatthew
left a comment
friendlymatthew
left a comment
There was a problem hiding this comment.
Looks great. Thank you very much @XiangpengHao
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #16
We only rely on
type_name.parse::<DataType>()to decide whether a type string is valid, I think this is consistent with thearrow_castbehavior in datafusion: https://github.com/apache/datafusion/blob/377c0fce481d561d58e3a6fad2dca18cb1d58384/datafusion/functions/src/core/arrow_cast.rs#L143-L147Added a few more test cases along the way.