Update cast_to_variant UDF to enhance variant handling and add new tests #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdf-jkl
reviewed
Dec 3, 2025
| fn from_array(_array: &ArrayRef) -> Result<ColumnarValue> { | ||
| todo!() | ||
| fn from_array(array: &ArrayRef) -> Result<ColumnarValue> { | ||
| // If the array is already a Variant array, pass it through unchanged |
| ScalarValue::UInt64(i) => build_variant_array(i.as_ref().map(|i| *i)), | ||
|
|
||
| _ => todo!(), | ||
| if let ScalarValue::Struct(struct_array) = scalar_value |
|
|
||
| use super::*; | ||
|
|
||
| #[test] |
Contributor
There was a problem hiding this comment.
tests look great!
Should we include other types in a next PR? (null, bool, decimal, timestamp/date/time, non-primitive ones like struct, list, map, union, dict, REE)
Member
There was a problem hiding this comment.
Here's an issue to track test coverage in cast_to_variant
friendlymatthew
approved these changes
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parts of #3
What changes in this pr?
Single-argument casts now delegate to parquet_variant_compute::cast_to_variant, so all Arrow types that kernel supports (strings/string views/large strings, fixed-size binary, numerics, temporal, lists/structs/maps/unions/etc.) work.
Existing Variant struct arrays are detected via VariantArray::try_new and passed through unchanged.
Two-argument metadata/value path kept as-is (binary-only).
Added return_field_from_args to emit a field with the VariantType extension and the canonical metadata/value struct shape.
New tests cover string arrays (StringArray, StringViewArray), fixed-size binary (16-byte), return-field extension tagging, plus prior scalar/array numeric and binary cases.