Skip to content

Conversation

@sdf-jkl
Copy link
Contributor

@sdf-jkl sdf-jkl commented Dec 3, 2025

This should be it...

Copy link
Member

@friendlymatthew friendlymatthew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sdf-jkl

I think it is recommended to place a short license header as a comment at the top of each source file, but I don't feel too strongly about it

Lmk if you feel otherwise, if not, I'll plan on merging

@sdf-jkl
Copy link
Contributor Author

sdf-jkl commented Dec 8, 2025

@friendlymatthew

Wording here makes it sound like headers are needed to make specific files use the license if the whole project is not using it.

This mentions that headers and NOTICE file are required for projects submitted directly to ASF.

Overall, we don't have to include headers and NOTICE file until this repo goes upstream.

We can merge.

@friendlymatthew friendlymatthew merged commit 51e0d4b into datafusion-contrib:main Dec 11, 2025
3 checks passed
@friendlymatthew
Copy link
Member

Thanks again @sdf-jkl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pick licensing

2 participants