-
Notifications
You must be signed in to change notification settings - Fork 23
Nan update, using #46 as base but without including 3rd party sources #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like Travis CI is failing with any of the older Node.js versions, due to desctructuring syntax in Mocha: /home/travis/build/dberesford/exiv2node/node_modules/mocha/bin/mocha:12
const {deprecate, warn} = require('../lib/utils'); |
|
@dberesford what would be your suggestion to go forward? |
|
I will take the liberty of dropping testing on versions before 8, based on them being no longer officially supported https://nodejs.org/en/about/releases/ Would be nice to get any info on what versions of Node.js is being used with |
|
A very useful update to use exiv2node with newer node versions! I've got some further changes in my fork to make it compatible with node 13. I'd be very grateful if @paazmaya or @m0g could give me some pointers on how I can get this to build on windows 10? How do I install exiv2 so that the build process can find it? Edit: I'm getting a little further now. First it could not find
|
|
@avgeeklucky sadly or better yet, luckily, I have not used windows for development for a long time, as it is just more straight forward in Linux and even in Mac... |
|
I prefer doing development on Linux too. But I prefer doing photo work on Windows, and I'm trying to get exiv2node to build for an Electron based photo organizer program Thanks anyway. |
|
I've got a windows build working, I've added instructions to README for anyone who's interested. Updated source code at avgeeklucky/exiv2node#nan-update-include-exiv2. I can open a third pull request along this line, @paazmaya you can merge it into this PR to keep things centralized. |
|
Thanks @avgeeklucky for the additions. |
This PR continues on top of what @m0g had done in #46, updates
nanto the latest version at the time of writing, removes the included 3rd party sources (since I want to get to use the latest distro installed packages), and makes some changes inInitAllmethod to make this thing build.I am looking for feedback and hoping to get at least some updates on the Node.js bindings, which I use in my projects...