Enum isn't sufficiently excluded #65
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be what's needed to prevent a SafeInt from being constructed from an enum, though a SafeInt of some defined type could be initialized from an enum. It still allows some things that don't especially make sense, like multiplying a SafeInt times an enum, or adding or several other things. It seems like that should be extremely unusual.
This also prevents SafeCast from casting TO an enum, though cast from an enum is by design.
An improvement that is not part of this fix is to discern the underlying type for an enum, which is possible for C++11 and later.