Skip to content

Conversation

@cmsdroff
Copy link
Contributor

@henrik dropped you a teams message here's the draft of the EQL API pending further input.

  • Gate Movement API - EDI CODECO Equivalent
  • Announcement API - for release and approval of containers to container facilities - EDI COPARN Equivalent
  • Hire API - In discussion with IICL - note the use of depot and Party in schema, lifted from the IICL Depot Lifecycle API we have a PR in with them mirroring here to allow discussion only in equipment calls.

Also added to the truckTransportCall in the event domain, created a new version as a minor non breaking change, we need to for the US add the Trucker SCAC to the Gate messages.

NOTE: still work to do on this API feedback pending.

@henrik
Copy link

henrik commented Feb 14, 2024

Wrong Henrik :)

@HenrikHL
Copy link
Contributor

Wrong Henrik :)

HAHAHA - it was meant for me. Thanks for letting us know @henrik

@github-actions
Copy link

Error: The following file(s) are not allowed to be changed: domain/event/event_domain_v3.2.1.yaml

@qodo-code-review
Copy link

CI Feedback 🧐

A test triggered by this PR failed. Here is an AI-generated analysis of the failure:

Action: check_changes

Failed stage: Check for forbidden changes [❌]

Failure summary:

The action failed because the GitHub Script detected changes to a forbidden file and explicitly
called core.setFailed.
- The script read .github/forbidden_changes.txt to obtain regex patterns of
disallowed paths.
- It compared the changed files against these patterns and found a violation.
- It
then set the job to failed with the message: You are not allowed to change the following file(s):
domain/event/event_domain_v3.2.1.yaml (see log line 197).

Relevant error logs:
1:  ##[group]Runner Image Provisioner
2:  Hosted Compute Agent
...

111:  git switch -c <new-branch-name>
112:  Or undo this operation with:
113:  git switch -
114:  Turn off this advice by setting config variable advice.detachedHead to false
115:  HEAD is now at 00e2431 Merge fb68f7b1c9392747d3647b56adbbfb1c6cef62c7 into 8e6aed40305011223d728116e1de1bd32eaaa434
116:  ##[endgroup]
117:  [command]/usr/bin/git log -1 --format=%H
118:  00e2431d0927939bcb009b0964572161ad31c39b
119:  ##[group]Run actions/github-script@v7
120:  with:
121:  script: const fs = require('fs');
122:  try {
123:    const forbiddenPaths = fs.readFileSync('.github/forbidden_changes.txt', 'utf8').split('\n').filter(path => path.trim() !== ''); // Read and filter empty lines
124:    console.log("Found valid lines (files): " + forbiddenPaths.length);
125:    return forbiddenPaths;
126:  } catch (error) {
127:    core.setFailed('Could not read forbidden paths file: ' + error.message);
128:    return [];
...

167:  const changedFiles = changedFilesString.split(',');
168:  
169:  let violations = [];
170:  
171:  changedFiles.forEach(file => {
172:    forbiddenPaths.forEach(forbiddenPath => {
173:      // console.log("Processing file: " + file + " with forbidden path: " + forbiddenPath);
174:      const regex = new RegExp(forbiddenPath); // Use regex for matching
175:      if (regex.test(file)) {
176:        violations.push(file);
177:      }
178:    });
179:  });
180:  
181:  if (violations.length > 0) {
182:    core.setFailed(`You are not allowed to change the following file(s): ${violations.join(', ')}`);
183:    // Create a comment on the PR
184:    await github.rest.issues.createComment({
185:      issue_number: context.issue.number,
186:      owner: context.repo.owner,
187:      repo: context.repo.repo,
188:      body: `**Error**: The following file(s) are not allowed to be changed: ${violations.join(', ')}`
189:    });
190:  }
191:  debug: false
192:  user-agent: actions/github-script
193:  result-encoding: json
194:  retries: 0
195:  retry-exempt-status-codes: 400,401,403,404,422
196:  ##[endgroup]
197:  ##[error]You are not allowed to change the following file(s): domain/event/event_domain_v3.2.1.yaml
198:  Post job cleanup.

@github-actions
Copy link

Error: The following file(s) are not allowed to be changed: domain/event/event_domain_v3.2.1.yaml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants