EBL 3.0: SD-2567: Add feedbacks to TD

[HenrikHL]

User description

SD-2567: Add feedbacks object to the TransportDocument
Update What's New

---

PR Type

Enhancement

---

Description

• Add feedbacks array property to TransportDocument schema

• Feedback types include unsupported properties, changed values, removed properties, general information

• References new Feedback schema component

---

Diagram Walkthrough

flowchart LR
  TD["TransportDocument"] -- "adds feedbacks array" --> FB["Feedback items"]
  FB -- "references" --> FS["Feedback schema"]

Loading

File Walkthrough

	Relevant files
Enhancement	EBL_v3.0.2.yaml Add feedbacks array to TransportDocument                                  ebl/v3/EBL_v3.0.2.yaml Added feedbacks array property to TransportDocument schema Includes descriptive documentation of feedback types References Feedback schema component via $ref +10/-0
Configuration changes	styleguide.json Styleguide configuration update                                                    .stoplight/styleguide.json Configuration file modified (insufficient details available) +1/-1

---

[qodo-code-review]

PR Compliance Guide 🔍

(Compliance updated until commit f859590)

Below is a summary of compliance checks for this PR:

Security Compliance
🟢	No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
⚪	🎫 No ticket provided Create ticket/issue
Codebase Duplication Compliance
⚪	Codebase context is not defined Follow the guide to enable codebase context checks.
Custom Compliance
🟢	Generic: Meaningful Naming and Self-Documenting Code Objective: Ensure all identifiers clearly express their purpose and intent, making code self-documenting Status: Passed
	Generic: Secure Error Handling Objective: To prevent the leakage of sensitive system information through error messages while providing sufficient detail for internal debugging. Status: Passed
	Generic: Secure Logging Practices Objective: To ensure logs are useful for debugging and auditing without exposing sensitive information like PII, PHI, or cardholder data. Status: Passed
⚪	Generic: Comprehensive Audit Trails Objective: To create a detailed and reliable record of critical system actions for security analysis and compliance. Status: Audit logging unclear: The added feedbacks array defines schema structure but provides no indication whether creation/update of feedback entries are audited with user, timestamp, action, and outcome. Referred Code feedbacks: type: array description: | Feedback that can be provided includes, but is not limited to: - unsupported properties - changed values - removed properties - general information items: $ref: '#/components/schemas/Feedback'
	Generic: Robust Error Handling and Edge Case Management Objective: Ensure comprehensive error handling that provides meaningful context and graceful degradation Status: Edge cases unspecified: The schema adds a feedbacks array without constraints or guidance on empty/null handling or validation of feedback items, leaving potential edge cases unspecified at the schema level. Referred Code feedbacks: type: array description: | Feedback that can be provided includes, but is not limited to: - unsupported properties - changed values - removed properties - general information items: $ref: '#/components/schemas/Feedback'
	Generic: Security-First Input Validation and Data Handling Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent vulnerabilities Status: Validation not defined: The new feedbacks array references Feedback items but does not specify array-level constraints (e.g., maxItems, uniqueness) or item validation details, which may impact input validation depending on the referenced schema. Referred Code feedbacks: type: array description: | Feedback that can be provided includes, but is not limited to: - unsupported properties - changed values - removed properties - general information items: $ref: '#/components/schemas/Feedback'

Compliance status legend

🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

---

Previous compliance checks

Compliance check up to commit 70e7d68

Security Compliance
🟢	No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
🟡	🎫 #SD-2567 🟢 Add a new feedbacks array property to the TransportDocument schema. Ensure feedbacks reference a Feedback schema component for its items. Describe supported feedback types: unsupported properties, changed values, removed properties, and general information. ⚪ Confirm that the referenced Feedback schema exists in the components section and matches intended structure (cannot be fully verified from partial diff).
Codebase Duplication Compliance
⚪	Codebase context is not defined Follow the guide to enable codebase context checks.
Custom Compliance
🟢	Generic: Meaningful Naming and Self-Documenting Code Objective: Ensure all identifiers clearly express their purpose and intent, making code self-documenting Status: Passed
	Generic: Secure Error Handling Objective: To prevent the leakage of sensitive system information through error messages while providing sufficient detail for internal debugging. Status: Passed
	Generic: Secure Logging Practices Objective: To ensure logs are useful for debugging and auditing without exposing sensitive information like PII, PHI, or cardholder data. Status: Passed
⚪	Generic: Comprehensive Audit Trails Objective: To create a detailed and reliable record of critical system actions for security analysis and compliance. Status: No auditing context: The added schema fields define data structure only and do not implement or demonstrate logging of critical actions, making audit compliance unverifiable from this diff alone. Referred Code feedbacks: type: array description: | Feedback that can be provided includes, but is not limited to: - unsupported properties - changed values - removed properties - general information items: $ref: '#/components/schemas/Feedback'
	Generic: Robust Error Handling and Edge Case Management Objective: Ensure comprehensive error handling that provides meaningful context and graceful degradation Status: No error handling: The change adds schema properties without executable logic, so error handling and edge case management cannot be assessed from this diff. Referred Code feedbacks: type: array description: | Feedback that can be provided includes, but is not limited to: - unsupported properties - changed values - removed properties - general information items: $ref: '#/components/schemas/Feedback'
	Generic: Security-First Input Validation and Data Handling Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent vulnerabilities Status: Validation unspecified: The new 'feedbacks' array references a 'Feedback' schema but provides no constraints or validation details here, so security and input validation adequacy cannot be confirmed from this diff. Referred Code feedbacks: type: array description: | Feedback that can be provided includes, but is not limited to: - unsupported properties - changed values - removed properties - general information items: $ref: '#/components/schemas/Feedback'

[qodo-code-review]

PR Code Suggestions ✨

No code suggestions found for the PR.