Bugfix: Files created by onetouch-ssh command are owned by single user #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c4540ca. Signed-off-by: Zbyszek Żółkiewski <zbyszek@onefellow.com>
…r - making it impossible to use in multi-user env
Contributor
Author
|
This also include one commit that improve hostname handling (not rely on system command but use golang function) |
dcu
requested changes
Aug 29, 2018
|
|
||
| func init() { | ||
| logFile, err := os.OpenFile(`/tmp/onetouch.log`, os.O_CREATE|os.O_APPEND|os.O_WRONLY, 0600) | ||
| user, err := user.Current() |
Owner
There was a problem hiding this comment.
this fails in some systems, especially before go 1.11. so we need to fallback. see utils/helpers.go for an example or we can store this log somewhere in the user's home
Contributor
Author
There was a problem hiding this comment.
ok so i suppose best would be store users logs in $HOME, best in ~/.onetouch.log ?
Owner
There was a problem hiding this comment.
I think ~/.onetouch/logs/ would be a better place
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #26