Update x509.php to parse ASN1_GENERALIZEDTIME #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parse also ASN1_GENERALIZEDTIME por nextUpdate and thisUpdate not only ASN1_UTCTIME.
| continue; | ||
| } | ||
| if($value['type'] == '17' && !array_key_exists('thisUpdate', $curr)) { | ||
| if(($value['type'] == '17' || $value['type'] == '18') && !array_key_exists('thisUpdate', $curr)) { |
Contributor
There was a problem hiding this comment.
Maybe better readability with in_array
if(in_array($value['type'], ['17', '18']) && !array_key_exists('thisUpdate', $curr)) {
Owner
There was a problem hiding this comment.
i also think that it is better to use in_array
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For very long nextUpdate CRL could contain ASN1_GENERALIZEDTIME instead of ASN1_UTCTIME.
Should we take that into account when parsing the x509 crl file?
Cheers,
Jacq