[107] debate configuration links #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TO-DO: parse boolean inputs, clock images, and sound packs
…nto 105-fix-the-about-footer-link
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Member
Author
|
I've found a bug of URL overlap when copying debate config more than once. A fix is underway. |
- URL overlap when copying motion more than once - URL params/config fields discrepancies - predefined clock images not working as parameters
Member
Author
|
As it turns out, even TDD can overlook some edge cases. I shudder to think what Lovecraftian monstrosities would be hiding in this PR, if it wasn't for the tests…
|
jakubmanczak
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #107. Since this feature will be crucial for integrating with the tournament planner, all code introduced by this PR is covered with e2e tests.
Now, while Playwright is a great testing library, it still has some issues. I had to stabilize many of my tests, because Playwright acted too fast and performed actions before the page could fully load. For instance, most interactive elements are initially rendered with default values (e.g. empty motion text box) and are filled with proper content (e.g. motion parsed from URL) after a short time window. For the end user, this is barely noticeable, but playwright often jumps right in the middle of that time window, snatching default values and what not, causing the tests to fail. I made several decisions regarding explicit waits and double-checks that I'm not proud of, but I was determined to write reliable tests, while keeping these questionable practices at a minimum.