-
Notifications
You must be signed in to change notification settings - Fork 188
feat(config): enable port dynamique assignment #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jqueguiner
commented
Nov 16, 2022
- still allow the user to define custom port as before
- default port (when not defined) remains the same (50050)
- if port_number is defined but is already in use we are assigning another port automagically
- if port_number is not defined and the default (50050) is already in use we are assigning another port automagically
@microsoft-github-policy-service agree [company="Gladia"] |
@microsoft-github-policy-service agree company=Gladia |
|
Thank you @jqueguiner! It looks like our formatter is failing, can you apply the formatter? Details here: https://github.com/microsoft/DeepSpeed-MII/blob/main/CONTRIBUTING.md#prerequisites |
mrwyattii
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this PR will completely solve the problem for multi-GPU setups. We expect the ports in range [port_number, port_number + num_gpu] to be open:
https://github.com/microsoft/DeepSpeed-MII/blob/747072b08a94129eb1a5d88bbaffa574b7bf039f/mii/server_client.py#L242
Perhaps we need to rethink how we are doing port numbers and find num_gpu open ports in the config.