Skip to content

Conversation

@ah-rahimi
Copy link
Contributor

@ah-rahimi ah-rahimi commented Nov 18, 2025

More implementation on #743 to customize the URL for a request.

about tests: It works like the setBaseUrl() and setHttpProxy() methods.

@ah-rahimi
Copy link
Contributor Author

Hi @fabio-ivona, @MarioGattolla.
Hope you are well.

Please check this for merge.
Thanks

@fabio-ivona
Copy link
Member

@ah-rahimi isn't enough the customizable bot url method to achieve this?

@ah-rahimi
Copy link
Contributor Author

@fabio-ivona, since I'm manually using the Telegraph Facade, that's not useful for me.

@ah-rahimi
Copy link
Contributor Author

ah-rahimi commented Nov 19, 2025

Hi, when will you merge it?
@fabio-ivona

@ah-rahimi
Copy link
Contributor Author

We need this for tomorrow.
We have a release
Thanks 🙏

@fabio-ivona

@fabio-ivona
Copy link
Member

Sorry @ah-rahimi I'm not 100% convinced of this, too much cognitive overload on the package

I need time to dive deeper into it and think a cleaner solution

@ah-rahimi
Copy link
Contributor Author

Yes, you're right
That's no problem.

@ah-rahimi
Copy link
Contributor Author

ah-rahimi commented Nov 19, 2025

Then, as you implemented, you have to define a custom URL for all BOTs
and this may not be interesting.
but this way you only define a custom URL for what you want.

And we need to create a new model and extend from TelegraphBot so we can customize it.

@fabio-ivona
Copy link
Member

Then, as you implemented, you have to define a custom URL for all BOTs and this may not be interesting. but this way you only define a custom URL for what you want.

And we need to create a new model and extend from TelegraphBot so we can customize it.

That's usually how customization works for Laravel

I'm planning a setup system in service provider for the upcoming V2 that will be a complete rewrite

Btw, in this weekend I'll work on a better url customization system for the V1

@ah-rahimi
Copy link
Contributor Author

Hi @fabio-ivona ,
Do you have any plans for this?
We still need this feature.
We will be glad to merge it sooner.

@fabio-ivona
Copy link
Member

Hi @fabio-ivona , Do you have any plans for this? We still need this feature. We will be glad to merge it sooner.

I'll work on this during this week, we are under an heavy workload, so very few time available

@ah-rahimi
Copy link
Contributor Author

Thanks @fabio-ivona

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants