-
-
Notifications
You must be signed in to change notification settings - Fork 140
Feat: can custom full url on a request #744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hi @fabio-ivona, @MarioGattolla. Please check this for merge. |
|
@ah-rahimi isn't enough the customizable bot url method to achieve this? |
|
@fabio-ivona, since I'm manually using the Telegraph Facade, that's not useful for me. |
|
Hi, when will you merge it? |
|
We need this for tomorrow. |
|
Sorry @ah-rahimi I'm not 100% convinced of this, too much cognitive overload on the package I need time to dive deeper into it and think a cleaner solution |
|
Yes, you're right |
|
Then, as you implemented, you have to define a custom URL for all BOTs And we need to create a new model and extend from TelegraphBot so we can customize it. |
That's usually how customization works for Laravel I'm planning a setup system in service provider for the upcoming V2 that will be a complete rewrite Btw, in this weekend I'll work on a better url customization system for the V1 |
|
Hi @fabio-ivona , |
I'll work on this during this week, we are under an heavy workload, so very few time available |
|
Thanks @fabio-ivona |
More implementation on #743 to customize the URL for a request.
about tests: It works like the
setBaseUrl()andsetHttpProxy()methods.