-
Notifications
You must be signed in to change notification settings - Fork 23
v3.5.0 with R update to 4.4.3, updating deprecated Ruby functions #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
beusj
wants to merge
36
commits into
degauss-org:master
Choose a base branch
from
beusj:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
a5eee26
Refactor geocoding processing with unique name repair
beusj 49a626b
Add row_index to geocoding results
beusj a35a8a9
Merge pull request #1 from beusj/beusj-patch-map
beusj 629a565
update to R 4.4.3 and update packages; add logging to R function
beusj f46375a
update ruby to reflect deprecation of File.exists?
beusj 6ee586e
fixed additional ruby compatibility issues
beusj c3c27cc
updates for caching
beusj ff2bc4e
update dockerfile
beusj 469f48e
changes to github workflow
beusj 03e0982
Initial plan
Copilot 9731ab9
Configure build-deploy-release workflow to trigger on v3.5.0 tag
Copilot 4fc2e84
Initial plan
Copilot de9bdd9
Update build-deploy-release.yaml to run on any push with a tag
Copilot fad035b
Merge pull request #2 from beusj/copilot/run-release-on-tag-v3-5-0
beusj efd6992
Merge branch 'master' into copilot/run-on-push-with-tag
beusj e2bdd5b
Merge pull request #3 from beusj/copilot/run-on-push-with-tag
beusj 9b13b61
Initial plan
Copilot 8971646
Update GitHub Actions to remove deprecated save-state command
Copilot 7bc3bb5
Merge pull request #4 from beusj/copilot/remove-deprecated-save-state…
beusj d08609e
Modify deployment username in workflow
beusj a96290a
planned .github workflow changes
beusj e4c3724
revert staging of database changes
beusj e9de1fc
undo logging changes to entrypoint.R
beusj 6d78d6d
add additional information about ruby geocoder
beusj 5fb898d
Build in user repo
beusj 6b21a0b
Add repository_dispatch event to workflow
beusj 4fdc600
Update GitHub Actions workflow for dynamic username
beusj c5e75d9
Fix typo in event trigger for PR workflow
beusj 1fb178b
Update manual build workflow for Docker images
beusj 64a1b4a
Rename manual_build.yml to build-manual.yml
beusj 984bf62
Refactor Dockerfile for optimized build and dependencies
reukiodo b22a2a6
Modify R package installation in Dockerfile
reukiodo 2cf5a95
Revert "Modify R package installation in Dockerfile"
beusj 4b007bb
Revert "Refactor Dockerfile for optimized build and dependencies"
beusj 79ac306
use env variable for geocoder db location
beusj 3828272
Revert "use env variable for geocoder db location"
beusj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,70 @@ | ||
| name: Manually Rebuild Docker | ||
|
|
||
| on: | ||
| workflow_dispatch: | ||
| inputs: | ||
| tag: | ||
| description: "Optional image tag to push (e.g., v1.2.3). If empty, use repo tag at HEAD or short SHA." | ||
| required: false | ||
| default: "" | ||
|
|
||
| jobs: | ||
| deploy-images: | ||
| runs-on: ubuntu-latest | ||
| env: | ||
| REGISTRY: ghcr.io | ||
| USERNAME: ${{ github.event.organization.login || github.repository_owner }} | ||
| REPOSITORY: geocoder | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 0 # needed to read tags | ||
|
|
||
| - name: Determine image tags | ||
| shell: bash | ||
| run: | | ||
| set -euo pipefail | ||
| IMAGE="${REGISTRY}/${USERNAME}/${REPOSITORY}" | ||
|
|
||
| INPUT_TAG="${{ github.event.inputs.tag }}" | ||
| if [ -n "$INPUT_TAG" ]; then | ||
| TAG="$INPUT_TAG" | ||
| else | ||
| # Use exact tag at HEAD if present; otherwise short SHA | ||
| TAG="$(git describe --tags --exact-match 2>/dev/null || true)" | ||
| if [ -z "$TAG" ]; then | ||
| TAG="$(git rev-parse --short HEAD)" | ||
| fi | ||
| fi | ||
|
|
||
| echo "image=${IMAGE}" >> "$GITHUB_ENV" | ||
| echo "tag=${TAG}" >> "$GITHUB_ENV" | ||
| echo "versioned=${IMAGE}:${TAG}" >> "$GITHUB_ENV" | ||
| echo "latest=${IMAGE}:latest" >> "$GITHUB_ENV" | ||
|
|
||
| echo "Will publish tags:" | ||
| echo " - ${IMAGE}:${TAG}" | ||
| echo " - ${IMAGE}:latest" | ||
|
|
||
| - name: Build image | ||
| run: | | ||
| docker build -t "${{ env.versioned }}" -t "${{ env.latest }}" . | ||
|
|
||
| - name: Test image | ||
| run: | | ||
| docker run --rm -v "${PWD}/test":/tmp "${{ env.versioned }}" my_address_file.csv | ||
| docker run --rm -v "${PWD}/test":/tmp "${{ env.versioned }}" my_address_file.csv 0.6 | ||
| docker run --rm -v "${PWD}/test":/tmp "${{ env.versioned }}" my_address_file.csv all | ||
|
|
||
| - name: Login to GHCR | ||
| uses: docker/login-action@v3 | ||
| with: | ||
| registry: ${{ env.REGISTRY }} | ||
| username: ${{ env.USERNAME }} | ||
| password: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
| - name: Push images | ||
| run: | | ||
| docker push "${{ env.versioned }}" | ||
| docker push "${{ env.latest }}" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| # Ruby Geocoder | ||
|
|
||
| See this reposotiory for more information. | ||
beusj marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| [https://github.com/geocommons/geocoder](https://github.com/geocommons/geocoder) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The manual build workflow does not specify GEOCODER_S3_LOCATION when building the Docker image, but the Dockerfile now requires it via the ADD instruction. This will cause manual builds to fail. The build command needs to include the build argument with an appropriate value.