-
Notifications
You must be signed in to change notification settings - Fork 26
Add support for NFS export advanced settings #214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
c49788d to
810823f
Compare
anupamaloke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fpfuetsch, thank you for submitting this PR. The code changes looks good. I just have a minor comment regarding removing the state sub-option argument for the secondary_groups. I would prefer to be as declarative as possible :-)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #214 +/- ##
==========================================
+ Coverage 90.35% 90.42% +0.06%
==========================================
Files 143 143
Lines 16766 16906 +140
Branches 2317 2347 +30
==========================================
+ Hits 15149 15287 +138
- Misses 946 949 +3
+ Partials 671 670 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
anupamaloke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: fpfuetsch <54020707+fpfuetsch@users.noreply.github.com>
Signed-off-by: fpfuetsch <54020707+fpfuetsch@users.noreply.github.com>
98e9a42 to
4b2c059
Compare
|
@anupamaloke could you run the test coverage check again please? |
Description
This PR enables configuration of advanced settings of a single NFS export like
map_lookup_uid.GitHub Issues
Fixes #213
Checklist:
How Has This Been Tested?