Skip to content

Conversation

@fpfuetsch
Copy link

@fpfuetsch fpfuetsch commented Nov 6, 2025

Description

This PR enables configuration of advanced settings of a single NFS export like map_lookup_uid.

GitHub Issues

Fixes #213

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, pep8, linting, or security issues
  • I have performed Ansible Sanity test using --docker default
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

  • Tested using local build

@fpfuetsch fpfuetsch marked this pull request as draft November 6, 2025 12:34
@fpfuetsch fpfuetsch marked this pull request as ready for review November 6, 2025 14:04
Copy link
Collaborator

@anupamaloke anupamaloke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fpfuetsch, thank you for submitting this PR. The code changes looks good. I just have a minor comment regarding removing the state sub-option argument for the secondary_groups. I would prefer to be as declarative as possible :-)

@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2025

Codecov Report

❌ Patch coverage is 92.46575% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.42%. Comparing base (da078f2) to head (4b2c059).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
plugins/modules/nfs.py 90.43% 7 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #214      +/-   ##
==========================================
+ Coverage   90.35%   90.42%   +0.06%     
==========================================
  Files         143      143              
  Lines       16766    16906     +140     
  Branches     2317     2347      +30     
==========================================
+ Hits        15149    15287     +138     
- Misses        946      949       +3     
+ Partials      671      670       -1     
Flag Coverage Δ
units 90.42% <92.46%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

anupamaloke
anupamaloke previously approved these changes Nov 10, 2025
Copy link
Collaborator

@anupamaloke anupamaloke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: fpfuetsch <54020707+fpfuetsch@users.noreply.github.com>
Signed-off-by: fpfuetsch <54020707+fpfuetsch@users.noreply.github.com>
@fpfuetsch
Copy link
Author

@anupamaloke could you run the test coverage check again please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE]: Add support for NFS export advanced settings

3 participants