Skip to content

Conversation

@baoy1
Copy link
Contributor

@baoy1 baoy1 commented Sep 18, 2025

For 4.x and above, auth login is preferred.
The code change helps to avoid certain scenarios, e.g. when cluster is not ready, login API will failed.

@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2025

Codecov Report

❌ Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.77%. Comparing base (bff17c6) to head (db84ca8).

Files with missing lines Patch % Lines
PyPowerFlex/base_client.py 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #53      +/-   ##
==========================================
+ Coverage   95.57%   95.77%   +0.19%     
==========================================
  Files          67       67              
  Lines        4114     4116       +2     
==========================================
+ Hits         3932     3942      +10     
+ Misses        182      174       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@baoy1 baoy1 merged commit d79ef23 into main Sep 18, 2025
6 checks passed
@baoy1 baoy1 deleted the baoy1/login_fix branch September 18, 2025 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants