-
Notifications
You must be signed in to change notification settings - Fork 0
Migration Rewards Vault #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration Rewards Vault #2
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great work! Ideally, it would be good to have the following tests:
- migrate pre-cliff, (attempt) claim pre-cliff
- migrate pre-cliff, claim post-cliff, pre-expiration
- migrate pre-cliff, claim post-expiration
- migrate post-cliff, pre-expiration, claim pre-expiration
- migrate post-cliff, pre-expiration, claim post-expiration
- migrate post-expiration, claim post-expiration
to verify that all the logic works as expected. Wdyt?
jrhea
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved! just a couple of additional nits
This PR adds the
MigrationRewardsVault. This vault locks the depositor's ELFI for 3 months and then unlocks a 5% APR bonus over the following two months. If users migrate after the cliff, their bonus period will start later, and they will receive a smaller bonus than if they had locked their ELFI earlier. Once the users claim their HD tokens, they stop receiving a bonus.