Skip to content

Conversation

@jalextowle
Copy link
Contributor

This PR adds the MigrationRewardsVault. This vault locks the depositor's ELFI for 3 months and then unlocks a 5% APR bonus over the following two months. If users migrate after the cliff, their bonus period will start later, and they will receive a smaller bonus than if they had locked their ELFI earlier. Once the users claim their HD tokens, they stop receiving a bonus.

Copy link

@jrhea jrhea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great work! Ideally, it would be good to have the following tests:

  • migrate pre-cliff, (attempt) claim pre-cliff
  • migrate pre-cliff, claim post-cliff, pre-expiration
  • migrate pre-cliff, claim post-expiration
  • migrate post-cliff, pre-expiration, claim pre-expiration
  • migrate post-cliff, pre-expiration, claim post-expiration
  • migrate post-expiration, claim post-expiration

to verify that all the logic works as expected. Wdyt?

Copy link

@jrhea jrhea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved! just a couple of additional nits

@jalextowle jalextowle merged commit 7673a4b into main Feb 25, 2025
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants