repro #72
repro #72
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @dentiny, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request is focused on debugging and reproducing a specific issue within the data storage and compaction system. It introduces targeted diagnostic logging in key areas of the codebase and adds a detailed, self-contained integration test to simulate and verify complex data lifecycle operations, particularly concerning row deletions and the interaction between Mooncake and Iceberg snapshots.
Highlights
- Debugging Output Added: Introduced several
println!statements incompactor.rsandsnapshot.rsto aid in debugging data compaction and Iceberg snapshot generation logic. These logs provide insights into row counts, filtered record batches, and snapshot parameters. - New Debugging Test Case: Added a comprehensive
test_debugasync function intests.rsto reproduce and validate complex scenarios involving data appends, deletions, Mooncake snapshots, Iceberg snapshots, and data compaction. This test simulates specific file deletion states and verifies the final Iceberg snapshot content. - Test Utility Enhancements: A new utility function
create_mooncake_snapshot_no_syncwas added totable_operation_test_utils.rsfor non-blocking snapshot creation in tests. Additionally, the visibility ofsync_mooncake_snapshot_and_create_new_by_iceberg_payloadwas changed topub(crate)for broader test utility.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request appears to add a test case for reproducing a specific bug, likely related to concurrent data compaction and Iceberg snapshots. While the added test is valuable for regression, it includes several debugging print statements that should be removed from the production code. Additionally, the new test function should be given a more descriptive name to improve maintainability.
| if data_file_to_compact.file_id.file_id.0 == 10000000000014100 { | ||
| println!("10000000000014100 row num = {}, puffin deleted row number = {}", total_num_rows, deleted_rows_num); | ||
| } | ||
| if data_file_to_compact.file_id.file_id.0 == 10000000000014300 { | ||
| println!("10000000000014300 row num = {}, puffin deleted row number = {}", total_num_rows, deleted_rows_num); | ||
| } | ||
|
|
There was a problem hiding this comment.
This block of println! statements appears to be for debugging. Please remove it before merging.
| if data_file_to_compact.file_id.file_id.0 == 10000000000014100 { | ||
| println!("10000000000014100 filtered record batch = {:?}", filtered_record_batch); | ||
| } | ||
| if data_file_to_compact.file_id.file_id.0 == 10000000000014300 { | ||
| println!("10000000000014300 filtered record batch = {:?}", filtered_record_batch); | ||
| } | ||
| if data_file_to_compact.file_id.file_id.0 == 10000000000059500 { | ||
| println!("10000000000059500 filtered record batch = {:?}", filtered_record_batch); | ||
| } | ||
|
|
||
|
|
There was a problem hiding this comment.
This block of println! statements also appears to be for debugging and should be removed.
| } | ||
|
|
||
| #[tokio::test] | ||
| async fn test_debug() { |
There was a problem hiding this comment.
The test name test_debug is not descriptive. Please rename it to reflect the scenario being tested, for example, test_concurrent_compaction_and_iceberg_snapshot or something similar that captures the essence of this complex interaction test.
| async fn test_debug() { | |
| async fn test_concurrent_compaction_and_iceberg_snapshot() { |
| println!("option = {:?}, flush by table write {}, flush lsn = {}, min ongoing {}", | ||
| opt.iceberg_snapshot_option, | ||
| flush_by_table_write, | ||
| flush_lsn, | ||
| task.min_ongoing_flush_lsn, | ||
| ); | ||
|
|
There was a problem hiding this comment.
This println! statement appears to be for debugging. Please remove it before merging.
|
|
||
| println!("should have iceberg payload?"); | ||
|
|
There was a problem hiding this comment.
This println! statement also seems to be for debugging and should be removed.
dentiny
force-pushed
the
hjiang/repro-dup
branch
from
f07b543 to
42a1c66
Compare
Summary
Briefly explain what this PR does.
Related Issues
Closes # or links to related issues.
Changes
Checklist