Hjiang/add delta storage option #89
Conversation
Summary of ChangesHello @dentiny, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds support for S3 and GCS as storage options for Delta Lake tables, which is a great enhancement. The approach of using open_table_with_storage_options and providing storage-specific configurations is correct. However, I've identified a couple of critical issues in the implementation that could lead to panics: one related to parsing local file paths as URLs, and another where error propagation was replaced with .unwrap(). I've also noted some leftover debugging statements that should be removed. Addressing these points will improve the robustness and production-readiness of the code.
| println!("storage option = {:?}", storage_options); | ||
| println!("location = {:?}", config.location); | ||
|
|
||
| let table_uri = Url::parse(&config.location).unwrap(); |
There was a problem hiding this comment.
Using Url::parse(&config.location).unwrap() is not safe and will cause a panic for local file paths that are not valid URLs (e.g., /tmp/my_table). This will break tests and functionality for local filesystem storage. You should handle local paths by converting them to file:// URLs. Also, using .unwrap() can lead to unrecoverable panics; it's better to propagate the error using ?.
let table_uri = if config.location.contains("://") {
Url::parse(&config.location)?
} else {
Url::from_file_path(&config.location).map_err(|()| {
crate::error::MoonlinkError::Generic {
msg: format!("Invalid local path for Delta table: {}", config.location),
}
})?
};| Err(_) => { | ||
| let arrow_schema = mooncake_table_metadata.schema.as_ref(); | ||
| let delta_schema_struct = deltalake::kernel::Schema::try_from_arrow(arrow_schema)?; | ||
| let delta_schema_struct = deltalake::kernel::Schema::try_from_arrow(arrow_schema).unwrap(); |
There was a problem hiding this comment.
The use of .unwrap() here is a regression from the previous error handling with ?. If try_from_arrow fails, this will cause a panic instead of propagating the error. Please revert to using ? or .map_err() to handle the potential error gracefully.
let delta_schema_struct = deltalake::kernel::Schema::try_from_arrow(arrow_schema)?;| println!("storage option = {:?}", storage_options); | ||
| println!("location = {:?}", config.location); |
There was a problem hiding this comment.
These println! statements appear to be for debugging purposes. Please remove them before merging.
Summary
Briefly explain what this PR does.
Related Issues
Closes # or links to related issues.
Changes
Checklist