Skip to content

Fix reduce operation for IN predicate #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
alukach wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fix reduce operation for IN predicate #123

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b77714
Add failing test
alukach Nov 13, 2025
b8345a8
Only reduce IN predicate if value is provided
alukach Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/expr.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,6 +257,11 @@ impl Expr {
/// let toexpr: Expr = Expr::from_str("20").unwrap();
/// assert_eq!(reduced, toexpr);
///
/// let fromexpr: Expr = Expr::from_str("cityName IN ('Toronto','Frankfurt','Tokyo','New York')").unwrap();
/// let reduced = fromexpr.reduce(None).unwrap();
/// let toexpr: Expr = Expr::from_str("cityName IN ('Toronto','Frankfurt','Tokyo','New York')").unwrap();
/// assert_eq!(reduced, toexpr);
///
/// let fromexpr: Expr = Expr::from_str("(bork=1) and (bork=1) and (bork=1 and true)").unwrap();
/// let reduced = fromexpr.reduce(Some(&item)).unwrap();
/// let toexpr: Expr = Expr::from_str("bork=1").unwrap();
Expand Down Expand Up @@ -446,6 +451,9 @@ impl Expr {
Ok(Expr::Operation { op, args })
}
} else if op == "in" {
let Some(_) = j else {
return Ok(Expr::Operation { op, args });
};
let l: String = left.to_text()?;
let r: HashSet<String> = right.try_into()?;
let isin: bool = r.contains(&l);
Expand Down
Loading