feat: Add scaling configuration support to Sync command and enhance t… #131
+109
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsonghuster
reviewed
Dec 30, 2025
src/subCommands/sync/index.ts
Outdated
| props.scalingConfig = { | ||
| minInstances: provisionConfig.defaultTarget || 0, | ||
| currentInstances: provisionConfig.current || 0, | ||
| targetInstances: provisionConfig.defaultTarget || 0, |
Contributor
There was a problem hiding this comment.
- provisionConfig 没有 targetInstances？
- currentInstances 和 targetInstances 是不是不用在导出中展示啊， 这个都是内部中间过程的东西
- enableOnDemandScaling 这个是什么？API 中有吗？
rsonghuster
reviewed
Dec 30, 2025
| if (isElasticInstance) { | ||
| props.provisionConfig = provisionConfig; | ||
| delete props.scalingConfig; | ||
| } else { |
Contributor
There was a problem hiding this comment.
这 else 的逻辑是不是只需要保留 scalingconfig, delete 掉 provisionConfig 就好呢
…ests - Add ScalingPolicy import from @alicloud/fc20230330 - Implement getFunctionScalingConfig functionality in Sync class - Handle scaling configuration in the write method with proper processing - Add proper handling for elastic instances and horizontal scaling policies - Fix test file by mocking ScalingPolicy import to resolve test failures - Add comprehensive tests for scaling configuration functionality - Enhance existing tests to cover the new scaling config features - Update method signatures to include scalingConfig parameter Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
rsonghuster
approved these changes
Dec 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ests