Add 4eku to frontend #456
Closed
Add 4eku to frontend #456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't cache assets forever until we have a build step that provide content-aware names (e.g. checksum suffix) (otherwise we'll have stale cache issues whenever we modify any of the assets without also changing their names) Add asset config from images, and make sure svgs are given the correct mime type Remove permission policies that chrome didn't recongise
Updated readme to explain the separate repos
It should have been updated along with this commit aodl/CO.DELTA@4ad6f89 But the frontend was overlook at the time
Also mentioned following Omega-vote, and add Prior Reviewers section
|
Dear @aodl, In order to potentially merge your code in this open-source repository and therefore proceed with your contribution, we need to have your approval on DFINITY's CLA. If you decide to agree with it, please visit this issue and read the instructions there. Once you have signed it, re-trigger the workflow on this PR to see if your code can be merged. — The DFINITY Foundation |
Author
|
This PR was raised against the wrong repo. Please disregard |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And mention following Omega-vote (instead of D-QUORUM directly), and add a 'Prior Reviewers' section