fix(ic-certified-assets): set the ic_env cookie only if the canister environment changed
#4446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r environment changed
adamspofford-dfinity
approved these changes
Dec 23, 2025
adamspofford-dfinity
pushed a commit
that referenced
this pull request
Dec 23, 2025
…r environment changed (#4446) # Description Sets the `ic_env` cookie for all HTML files only if the canister environment changed in the `commit_batch` method. The feature was first introduced in #4387. # How Has This Been Tested? Successfully deployed the [dfinity/portal](https://github.com/dfinity/portal) locally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sets the
ic_envcookie for all HTML files only if the canister environment changed in thecommit_batchmethod.The feature was first introduced in #4387.
How Has This Been Tested?
Successfully deployed the dfinity/portal locally.
Checklist: