feat: self-calling asset canister #4450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamspofford-dfinity
approved these changes
Jan 6, 2026
Contributor
adamspofford-dfinity
left a comment
adamspofford-dfinity
left a comment
There was a problem hiding this comment.
LGTM with note
| F: FnMut(P) -> ComputationStatus<D, P, E>, | ||
| P: Default, | ||
| { | ||
| const INSTRUCTION_THRESHOLD: u64 = 35_000_000_000; // At the time of writing, 40b instructions are the limit for single message |
Contributor
There was a problem hiding this comment.
Is this limit low enough? The worst single hashing operation I saw was 3b instructions (press-kit.zip).
Contributor
Author
There was a problem hiding this comment.
Should be fine as we now hash a single chunk at a time (limited by the ingress message size) and no longer an entire file. From what I measured a single chunk should not take more than ~2MB*80 instructions
I also tested this with a 700MB file, which took ~50b instructions to hash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Try not running out of instructions during
commit_batch,compute_mvidence, andcompute_state_hashusing self-callsHow Has This Been Tested?
Mostly manually. e2e covers a lot of base functionality, but not big projects that may hit some limits.
Manual tests performed:
portalwith dfx 0.29.2, upgrade over it with this versionportalwith this version, do an edit and redeploycommit_batch completed: counter 0: 19221556022, counter 1: 54288949009(19b and 54b instructions forperformance_counter(0)and(1)Checklist: