Skip to content

Conversation

@diegozea
Copy link
Owner

Summary

  • align MMCIF printing defaults with reader expectations so write_file produces label-based mmCIF output
  • add a read/write/read roundtrip test for MMCIFFile to guard against regressions

Testing

  • julia --project -e 'push!(LOAD_PATH, "test"); using MIToSTests; MIToSTests.retest("PDB"); MIToSTests.retest("PDB")'

Codex Task

@codecov
Copy link

codecov bot commented Dec 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.97%. Comparing base (4a26a3d) to head (3ba0bdb).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #191   +/-   ##
=======================================
  Coverage   96.97%   96.97%           
=======================================
  Files          64       64           
  Lines        4861     4861           
=======================================
  Hits         4714     4714           
  Misses        147      147           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coveralls
Copy link

Coverage Status

coverage: 97.156%. remained the same
when pulling 49bd91a on codex/add-roundtrip-test-for-mmciffile
into 4a26a3d on master.

@diegozea diegozea changed the title Fix MMCIF roundtrip writing Fix MMCIF roundtrip writing, closes #190 Dec 11, 2025
@diegozea diegozea merged commit 42d96df into master Dec 11, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants