-
Notifications
You must be signed in to change notification settings - Fork 4
Feature/pose comparison #161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/2.0.0
Are you sure you want to change the base?
Conversation
Update manifest.yml
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Fix: skip v1.3.1 following mismatch between manifest and tags in github dating back from may
|
…the longest axis of the beam as x and normal of the largest face as y
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…the longest axis of the beam as x and normal of the largest face as y
…nd detects if list or history is passed
| if bc > 1: | ||
| poses_per_beam = i_measured_planes.Branches | ||
| for beam_id, poses in enumerate(poses_per_beam): | ||
| o_distances.append(bc * []) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably the bc is not needed here.. bc * [ ] = [ ] Not a problem just confusing :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If bc > 1, it means the full history has been given to compare with, so each of the N beam we have N poses to compare with. It sems to me we need the bc * []
…tection on point cloud side



This PR concerns the creation of a pose comparison component.

It also concerns a slight refactoring to better integrate the novelties of df2 in df1's logic: for now the integration is not as good as possible