Moved resample out of parsers to its own sub-package #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobleesj
reviewed
Nov 6, 2024
src/diffpy/utils/parsers/__init__.py
Outdated
|
|
||
| # silence the pyflakes syntax checker | ||
| assert loadData or resample or True | ||
| assert loadData or True |
Contributor
There was a problem hiding this comment.
I am afraid this isn't the latest cookiecutting standard for handling __init__.py files within src. Could you please check whether we have to import these functions lilke from .loaddata import loadData?
Author
There was a problem hiding this comment.
No we don't, I will delete these then
Contributor
|
@alisnwu Thanks for this quick fix. For future PRs, since pytest is running via GitHub CI, we don't have to attach the screenshot but appreciate the idea. |
Contributor
|
@alisnwu this sseems to have picked up a conflict |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #138
@sbillinge ready for review