add deprecation warning to resample function #207
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #207 +/- ##
==========================================
+ Coverage 93.97% 96.54% +2.56%
==========================================
Files 8 8
Lines 299 347 +48
==========================================
+ Hits 281 335 +54
+ Misses 18 12 -6 |
sbillinge
reviewed
Dec 8, 2024
news/resampler-dep-warn.rst
Outdated
| @@ -0,0 +1,23 @@ | |||
| **Added:** | |||
|
|
|||
| * Deprecation warning for resample function in resampler | |||
Contributor
There was a problem hiding this comment.
we are not adding functionality so move this from here to Deprecated
Author
|
@sbillinge fixed news item, ready for review |
sbillinge
reviewed
Dec 8, 2024
news/resampler-dep-warn.rst
Outdated
| **Deprecated:** | ||
|
|
||
| * <news item> | ||
| * Deprecation warning for resample function in resampler |
Contributor
There was a problem hiding this comment.
how about "resample function in resampler. Repaced with wsinterp" or sthg like that?
This news is user-facing so it should be targeted at someone who might be using the code.
Contributor
|
@alisnwu why are you closing this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #139
as per discussion in #180 warnings.warn passes pytest under python 3.13, 3.12, 3.11
@sbillinge @bobleesj ready for review